Fix so that fun() in Erlang does not try to generate any link
#2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 💙 💜 💛 ❤️ |
|
@josevalim When you have the time it would be great with another rc with this change. I've now built ex_doc locally and everything works as it should. |
|
RC2 is out. Once you are all happy with it let me know and I can ship final! |
|
Thanks! I will test it now. |
|
Testing takes a while, but now it is all done and working as it should. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that there actually was a test for this, but as the codepath was Elixir 1.18 only it was never tested in CI. So this PR adds Elixir 1.18 to the CI matrix and fixes the fun problem.
Fixes regression in #1980