Fix strip_app to always rewrap in a list #2124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/14968644553/artifacts/3104690552 |
|
💚 💙 💜 💛 ❤️ |
|
When you have the time, we would appriciate a new release as well :) |
|
@garazdawi can you please confirm this is good then? 0840140 |
|
I think that the things introduced in this commit are no longer done, but we seem to have fixed most of them so I will just fix the remaining ones so that we don't need that workaround anymore. When I fixed that all tests passed with 0840140. |
|
Yeah, we also changed synopsis to rely on AST, so it is way more reliable and precise now. So I will go ahead and cut a new release, worst case scenario I do another one later :) |
|
thanks! |
|
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash I described in #2122 was not because of edoc producing docs without a list wrapper, but because the Erlang layer in ExDoc did so. My initial suggestion just happened to work as it also fixed this issue, but the final fix of normalizting edoc input did not as it happened to early.
This PR fixes the issue though I could not manage to create a testcase that replicates it.