add sanity checks in more places

elixir-lsp · Jan 1, 2024 · c60fd9e · c60fd9e
1 parent 27013d3
commit c60fd9e
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 9 deletions.
diff --git a/apps/language_server/lib/language_server/dialyzer.ex b/apps/language_server/lib/language_server/dialyzer.ex
@@ -228,6 +228,7 @@ defmodule ElixirLS.LanguageServer.Dialyzer do
         :ok
 
       _other ->
+        ElixirLS.LanguageServer.Server.do_sanity_check()
         message = Exception.format_exit(reason)
 
         JsonRpc.telemetry(

diff --git a/apps/language_server/lib/language_server/ex_unit_test_tracer.ex b/apps/language_server/lib/language_server/ex_unit_test_tracer.ex
@@ -51,6 +51,7 @@ defmodule ElixirLS.LanguageServer.ExUnitTestTracer do
         :ok
 
       _other ->
+        ElixirLS.LanguageServer.Server.do_sanity_check()
         message = Exception.format_exit(reason)
 
         JsonRpc.telemetry(

diff --git a/apps/language_server/lib/language_server/mix_project_cache.ex b/apps/language_server/lib/language_server/mix_project_cache.ex
@@ -149,6 +149,7 @@ defmodule ElixirLS.LanguageServer.MixProjectCache do
         :ok
 
       _other ->
+        ElixirLS.LanguageServer.Server.do_sanity_check()
         message = Exception.format_exit(reason)
 
         JsonRpc.telemetry(

diff --git a/apps/language_server/lib/language_server/parser.ex b/apps/language_server/lib/language_server/parser.ex
@@ -95,8 +95,8 @@ defmodule ElixirLS.LanguageServer.Parser do
         :ok
 
       _other ->
+        ElixirLS.LanguageServer.Server.do_sanity_check()
         message = Exception.format_exit(reason)
-
         JsonRpc.telemetry(
           "lsp_server_error",
           %{

diff --git a/apps/language_server/lib/language_server/providers/workspace_symbols.ex b/apps/language_server/lib/language_server/providers/workspace_symbols.ex
@@ -118,6 +118,7 @@ defmodule ElixirLS.LanguageServer.Providers.WorkspaceSymbols do
         :ok
 
       _other ->
+        ElixirLS.LanguageServer.Server.do_sanity_check()
         message = Exception.format_exit(reason)
 
         JsonRpc.telemetry(

diff --git a/apps/language_server/lib/language_server/server.ex b/apps/language_server/lib/language_server/server.ex
@@ -156,7 +156,7 @@ defmodule ElixirLS.LanguageServer.Server do
   end
 
   @impl GenServer
-  def terminate(reason, _state) do
+  def terminate(reason, state) do
     case reason do
       :normal ->
         :ok
@@ -168,6 +168,7 @@ defmodule ElixirLS.LanguageServer.Server do
         :ok
 
       _other ->
+        do_sanity_check()
         message = Exception.format_exit(reason)
 
         JsonRpc.telemetry(
@@ -207,7 +208,7 @@ defmodule ElixirLS.LanguageServer.Server do
           {:error, type, msg, send_telemetry} ->
             JsonRpc.respond_with_error(id, type, msg)
 
-            do_sanity_check(state)
+            do_sanity_check()
 
             if send_telemetry do
               JsonRpc.telemetry(
@@ -419,7 +420,7 @@ defmodule ElixirLS.LanguageServer.Server do
         error_msg = Exception.format_exit(reason)
         JsonRpc.respond_with_error(id, :internal_error, error_msg)
 
-        do_sanity_check(state)
+        do_sanity_check()
 
         JsonRpc.telemetry(
           "lsp_request_error",
@@ -780,7 +781,7 @@ defmodule ElixirLS.LanguageServer.Server do
               "retry" => false
             })
 
-            do_sanity_check(state)
+            do_sanity_check()
 
             JsonRpc.telemetry(
               "lsp_request_error",
@@ -847,7 +848,7 @@ defmodule ElixirLS.LanguageServer.Server do
         {:error, type, msg, send_telemetry, state} ->
           JsonRpc.respond_with_error(id, type, msg)
 
-          do_sanity_check(state)
+          do_sanity_check()
 
           if send_telemetry do
             JsonRpc.telemetry(
@@ -893,7 +894,7 @@ defmodule ElixirLS.LanguageServer.Server do
         error_msg = Exception.format(kind, payload, stacktrace)
         JsonRpc.respond_with_error(id, :internal_error, error_msg)
 
-        do_sanity_check(state)
+        do_sanity_check()
 
         JsonRpc.telemetry(
           "lsp_request_error",
@@ -1481,7 +1482,7 @@ defmodule ElixirLS.LanguageServer.Server do
   end
 
   defp handle_build_result(status, diagnostics, state = %__MODULE__{}) do
-    do_sanity_check(state)
+    do_sanity_check()
 
     state =
       if state.needs_build? or status == :error or not dialyzer_enabled?(state) do
@@ -2243,7 +2244,7 @@ defmodule ElixirLS.LanguageServer.Server do
     end
   end
 
-  defp do_sanity_check(_state) do
+  def do_sanity_check() do
     try do
       unless :persistent_term.get(:language_server_test_mode, false) do
         unless function_exported?(ElixirSense, :module_info, 1) and

diff --git a/apps/language_server/lib/language_server/tracer.ex b/apps/language_server/lib/language_server/tracer.ex
@@ -140,6 +140,7 @@ defmodule ElixirLS.LanguageServer.Tracer do
         :ok
 
       _other ->
+        ElixirLS.LanguageServer.Server.do_sanity_check()
         message = Exception.format_exit(reason)
 
         JsonRpc.telemetry(