Workspace symbols refactor #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make it consider only symbols from the project. Previously all available symbols were scanned - return results on empty query. Previously no results were returned due to perf problems - reimplemented search engine using elixir_sense Matcher similar to complete - deduplication of functions with default args added - return containerName - return deprecated tag if supported - return distinct symbol kind on macros, behaviours, structs
…pace symbols this adds visual distinction between functions and macros in completions (at least in VSCode)
fixes an issue when workspace symbols would not see a newly added module due to app controller keeping old module list Workaround for elixir-lang/elixir#13001
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces many improvements to workspace symbols provider