Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close sockets on transport errors in Mint.HTTP1 #416

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Close sockets on transport errors in Mint.HTTP1 #416

merged 1 commit into from
Dec 11, 2023

Conversation

whatyouhide
Copy link
Contributor

Closes #415.

@whatyouhide whatyouhide mentioned this pull request Dec 8, 2023
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

Pull Request Test Coverage Report for Build c7b117cb9d657cf44f2691054dc13d63873565f0-PR-416

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 87.579%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/mint/http1.ex 0 3 0.0%
Totals Coverage Status
Change from base Build fe80d7ec248763f7d912acd3c52f39655f4d9acd: -0.06%
Covered Lines: 1248
Relevant Lines: 1425
💛 - Coveralls

@whatyouhide whatyouhide requested a review from ericmj December 8, 2023 07:55
@whatyouhide whatyouhide merged commit 56edf53 into main Dec 11, 2023
4 checks passed
@whatyouhide whatyouhide deleted the al/fix-leak branch December 11, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmj ericmj Awaiting requested review from ericmj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mint.HTTP1 leaks socket upon receive timeout
1 participant
@whatyouhide