Replace Util.downcase_ascii with String.downcase(&1, :ascii) #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmj
approved these changes
Feb 10, 2024
lib/mint/http1/parse.ex
Outdated
| @@ -68,4 +68,8 @@ defmodule Mint.HTTP1.Parse do | |||
| do: token_list_downcase(rest, acc) | |||
|
|
|||
| defp token_list_sep_downcase(_rest, _acc), do: :error | |||
|
|
|||
| @spec downcase_ascii_char(byte()) :: byte() | |||
There was a problem hiding this comment.
We usually don't add specs to private functions.
Suggested change
| @spec downcase_ascii_char(byte()) :: byte() |
Also moved downcase_ascii_char/1 to HTTP1.Parse as it's the only module that uses it now.
IceDragon200
force-pushed
the
string-downcase
branch
from
bf7c56e to
9fe9444
Compare
|
I'll fix the warnings locally. Thanks @IceDragon200 💟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes calls to Mint's original
downcase_ascii/1which was found to be slower than Elixir's stock downcase with the:asciioption.Related
Closes #420
Notes
I unrolled HTTP1.Parser.header_name/1's atom case for clarity, as inline pipes on the same line can be hard to read, I hope this is okay.