Make make_binary faster #300
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
force-pushed
the
faster-bins
branch
from
f0ae237
to
6dfdf63
Compare
ruslandoga
force-pushed
the
faster-bins
branch
from
999a6d3
to
5194aa0
Compare
ruslandoga
commented
Oct 9, 2024
|
|
||
| alias Exqlite.Sqlite3 | ||
|
|
||
| Benchee.run( |
There was a problem hiding this comment.
The benchmark will be removed before merging.
warmwaffles
reviewed
Oct 9, 2024
|
|
||
| return term; | ||
| ERL_NIF_TERM bin; | ||
| const char* data = enif_make_new_binary(env, size, &bin); |
There was a problem hiding this comment.
I think I didn't use this function because of the documentation: https://www.erlang.org/doc/apps/erts/erl_nif.html#enif_make_new_binary
The drawbacks are that the binary cannot be kept between NIF calls and it cannot be reallocated.
Is this saying that we shouldn't store it in a global static ERL_NIF_TERM and that it should be safe to pass back to the VM but don't rely on it being present?
There was a problem hiding this comment.
Yes, I think that's what it means. I'm pretty sure it's safe to use since Exqlite only keeps conn and stmt resources between nif calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs this version would try to allocate small binaries on the process heap, which seems to positively affect benchmarks (xqlite uses this approach).