Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add url policy to logger middleware #760

Closed
wants to merge 1 commit into from

Conversation

yordis
Copy link
Member

@yordis yordis commented Mar 12, 2025

No description provided.

@yordis yordis force-pushed the feat-url-policy-logger branch from 4e7db88 to 06b2632 Compare March 12, 2025 21:02
@yordis yordis force-pushed the feat-url-policy-logger branch from 06b2632 to 460361d Compare March 12, 2025 21:05
@yordis
Copy link
Member Author

yordis commented Mar 12, 2025

@teamon I am still unsure if this idea should be custom-formatted in the app instead of extending the logger's behaviour.

Primarily because the configuration only makes sense for the default format AND requires proper middleware setup.

I am inclined to recommend that people create their format after thinking about it 🤔

I suggest providing another formatting function that people could opt for in a similar situation.

@yordis yordis closed this Mar 12, 2025
@yordis
Copy link
Member Author

yordis commented Mar 12, 2025

I talked myself out, custom formatter should be the solution here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant