-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python lockfile creation to new releases #3041
base: main
Are you sure you want to change the base?
Conversation
elyra/contents/handlers.py
Outdated
@@ -74,3 +74,6 @@ def _get_absolute_path(self, path: str) -> str: | |||
path = path[1:] | |||
absolute_path = os.path.normpath(os.path.join(root_dir, path)) | |||
return absolute_path | |||
|
|||
def write_error(self, status_code, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is something flagging these as necessary? Seems like write_error()
resolution would be satisfied by the mixin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL is showing warnings for this. seems they want you to explicitly define which method we use despite it always resolving from left to right in terms of inheritance. Guess its for clarity.
0eb7f0d
to
85e9afe
Compare
Signed-off-by: Alan Chin <[email protected]>
Dependent on #3038
Per LFAI onboarding, releases need to be reproducible. In addition to the yarn.lock file, the release process will now include a python lockfile (requirements.txt) generated at build time which includes explicit listing direct and indirect dependencies and their hash signatures.
What changes were proposed in this pull request?
How was this pull request tested?
Developer's Certificate of Origin 1.1