[semantic-tokens] Add support for semantic tokens faces overrides #2826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsp-semantic-tokens.el
Outdated
| @@ -378,6 +378,23 @@ IS-RANGE-PROVIDER is non-nil when server supports range requests." | |||
| (lsp-warn "No face has been associated to the %s '%s': consider adding a corresponding definition to %s" | |||
| category id varname)) maybe-face)) identifiers))) | |||
|
|
|||
| (defun lsp-semantic-tokens--replace-alist-values (a b) | |||
| "Replace alist A values with B ones if exists." | |||
There was a problem hiding this comment.
if exists sounds strange; not sure how to formulate this correctly without blowing up the docstring's length though. Maybe "if present" or "where available" would be slightly better?
Apart from that, the changes look good to me and seem to work as intended (tested with clojure-lsp)
sebastiansturm
approved these changes
May 2, 2021
foldu
pushed a commit
to foldu/lsp-mode
that referenced
this pull request
May 4, 2021
…acs-lsp#2826) * Add support for semantic tokens faces overrides * Improve doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2448 (comment)
semantic-tokens-faces-overrideswith support for:typesand:modifiers.This should allow specific clients to replace the default lsp faces with custom ones.
Rationale: It's common for major modes to use different faces for their symbols, with that we could share the same faces that major modes like
clojure-modeuses, reducing the impact to users and following the same standard.