WIP: Fix for #369 #371
Open
WIP: Fix for #369 #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work in progress: Fix for issue emacs-lsp#369. Theme changes won't update background color and fringe width automatically. Previously, there was advice to delete frame after load-theme. This commit changes this to instead update background color and fringe width after load-theme and also after custom-set-faces. Note especially that - This fix is not tested with webkit. - If other features than :background are set in lsp-ui-doc-background face, then the inline mode might use them. Added documentation to advice against this.
|
I will try to test this the next days. |
brotzeit
force-pushed
the
master
branch
2 times, most recently
from
dfa421f
to
134d9b7
Compare
|
This problem still exists: changing color for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress: Fix for issue #369.
Theme changes won't update background color and fringe width
automatically. Previously, there was advice to delete frame after
load-theme. This commit changes this to instead update background
color and fringe width after load-theme and also after
custom-set-faces.
Note especially that
face, then the inline mode might use them. Added documentation to
advice against this.