Manually implement the future for with_timeout
#4123
Merged
+42
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirbaio
reviewed
Apr 23, 2025
embassy-time/src/timer.rs
Outdated
|
|
||
| /// Future for the [`with_timeout`] and [`with_deadline`] functions. | ||
| #[must_use = "futures do nothing unless you `.await` or poll them"] | ||
| pub struct UntilTimer<F> { |
There was a problem hiding this comment.
could you rename this to TimeoutFuture?
It makes sense to call xxxFuture things that implement Future
alexmoon
force-pushed
the
manual-with-timeout-impl
branch
from
5ace4c8 to
4d91140
Compare
alexmoon
force-pushed
the
manual-with-timeout-impl
branch
from
4d91140 to
0b8f43b
Compare
|
Thanks! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Noticed that after updating embassy with this PR merged my firmware size dropped by a few % for both flash and RAM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
async fnfor these functions causes the memory forfutto be double-allocated due to rust-lang/rust#62958. Switching to a manual implementation of the future prevents the double-allocation which may be significant if the future is large.