Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add commonly used file extensions #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

st-h
Copy link

@st-h st-h commented Sep 18, 2020

from emberjs/rfcs#648 this PR adds default support for file suffixes: svg, webp, mp4, webmanifest and json

from emberjs/rfcs#648 this PR adds default support for file suffixes: `svg`, `webp`, `mp4`, `webmanifest` and `json`
@sandstrom
Copy link

Good idea!

No biggie, but is 'webmanifest' common enough to warrant default inclusion?

I'd never heard of it and browser support isn't very good (not supported by Safari, for example). Still labeled as "experimental" by MDN.

@st-h
Copy link
Author

st-h commented Jan 3, 2021

@sandstrom sorry about not getting back to this any earlier. Support isn't that bad per se: https://caniuse.com/?search=manifest

Additionally it seems to be better to support more commonly used items than less, since this also configures which file types to use the prepend option for. Any missing file types will cause loading of these resources to fail.

Otherwise: is there any issue which is preventing us from merging? I had opened an RFC previously and there did not seem to be any objections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants