Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure we only endup with one assetMap when fingerprintAssetMap is true #146

Closed
wants to merge 1 commit into from

Conversation

betocantu93
Copy link

@betocantu93 betocantu93 commented Mar 13, 2021

Overview

When using the option fingerprintAssetMap: true you end up with two different versions of the assetMap.json by default i.e.

assetMapPath - Default: 'assets/assetMap-HASH.json'

It seems Fingerprint.prototype.writeAssetMap gets called multiple times (2 at least) by the build process, I honestly don't know if this is normal or how to go deeper on this topic... so for each call an assetMap.json is written with a different md5 hash, also it seems that each call is incremental, meaning it always have the first's call assets plus new ones found I guess.

Alternatively when using fingerprintAssetMap: false the fileName stays the same in each call and so it gets effectively overwritten by the last writeAssetMap execution, so this "bug" actually always exists, its just hidden when using the default value fingerprintAssetMap: false.

Patch/Fix

There's prob a better way to do this, but for now, save the assetMapHash for latter reuse, so we basically overwrite the file, like when using fingerprintAssetMap: false

Related Issues

#122

@betocantu93 betocantu93 changed the title ensure we only endup with one assetMap? ensure we only endup with one assetMap when fingerprintAssetMap is true Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant