ensure we only endup with one assetMap when fingerprintAssetMap is true #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When using the option
fingerprintAssetMap: true
you end up with two different versions of the assetMap.json by default i.e.assetMapPath - Default: 'assets/assetMap-HASH.json'
It seems
Fingerprint.prototype.writeAssetMap
gets called multiple times (2 at least) by the build process, I honestly don't know if this is normal or how to go deeper on this topic... so for each call an assetMap.json is written with a different md5 hash, also it seems that each call is incremental, meaning it always have the first's call assets plus new ones found I guess.Alternatively when using
fingerprintAssetMap: false
thefileName
stays the same in each call and so it gets effectively overwritten by the last writeAssetMap execution, so this "bug" actually always exists, its just hidden when using the default valuefingerprintAssetMap: false
.Patch/Fix
There's prob a better way to do this, but for now, save the assetMapHash for latter reuse, so we basically overwrite the file, like when using
fingerprintAssetMap: false
Related Issues
#122