Add svg as a default file extension
#80
Conversation
[Modern browsers][caniuse] now support `svg` as a valid [`background-image` value][background]. We should support this out of the box, without additional configuration. [caniuse]: http://caniuse.com/#feat=svg-css [background]: https://css-tricks.com/using-svg/
seanpdoyle
force-pushed
the
sd-svg-default-extension
branch
from
02d0b17 to
5355fb7
Compare
|
The only reason I'm hesitant to add this is because it is a breaking change and will prevent people from getting future bug fixes who have |
|
I agree, it would certainly require at least a minor version bump, but in what way would previous behavior be "broken".
|
|
Well someone could explicitly not want svg's to be fingerprinted so I would consider this a major breaking change. |
|
@rickharrison good point. Is a major version bump anywhere on the horizon, or is this a bonafide Bad Idea ™️ ? |
|
I think it might be a good idea to save this for the next major version. I do have ideas for an internal refactoring to split some things out. I don't have an immediate timeline for that, but its something I'd like to do in the near future. |
|
Relevant: #88 |
|
Closing in favor of #88. |
Modern browsers now support
svgas a validbackground-imagevalue.We should support this out of the box, without additional configuration.