Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add code documention for some functions called in the index module #1079

Merged
merged 8 commits into from
Dec 17, 2020

Conversation

gitstevenpham
Copy link
Contributor

@gitstevenpham gitstevenpham commented Dec 10, 2020

Small refactor in the index module that takes setting up a passed in package and blueprint name into another function. Changes are mostly adding code documentation from my experience trying to understand the code flow of the index module

@gitstevenpham gitstevenpham marked this pull request as ready for review December 15, 2020 01:03
@gitstevenpham
Copy link
Contributor Author

gitstevenpham commented Dec 15, 2020

yarn test:fast seems to be failing even for the fresh repository state. @kellyselden can you verify there's something broken with the current tests ?

[Edit] Nvm looks like we can't include yarn.lock since integration tests uses the current working directory which is the current project

.gitignore Outdated Show resolved Hide resolved
@gitstevenpham
Copy link
Contributor Author

@kellyselden can you checkout this pull request and merge

@rwjblue
Copy link
Member

rwjblue commented Dec 17, 2020

FWIW, #1085 is documenting the CI failure here.

@rwjblue rwjblue merged commit 506c5ae into ember-cli:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants