Skip to content

Remove routes #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 26, 2025
Merged

Remove routes #951

merged 5 commits into from
May 26, 2025

Conversation

mansona
Copy link
Member

@mansona mansona commented May 26, 2025

This fixes a few problems with #909

We removed the tabbed layout but we didn't actually remove the routes for that tabbed laout, and it turns out that the tabs/routes were done in possibly the most confusing possible way 🙈

This PR removes those routes and cleans up all the mess that was left over

Copy link

netlify bot commented May 26, 2025

Deploy Preview for ember-api-docs ready!

Name Link
🔨 Latest commit 0f8f1be
🔍 Latest deploy log https://app.netlify.com/projects/ember-api-docs/deploys/683449fa81577400086596c5
😎 Deploy Preview https://deploy-preview-951--ember-api-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mansona mansona requested a review from MinThaMie May 26, 2025 11:09
Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow :) I did not look into this yet! thanks!

Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow :) I did not look into this yet! thanks!

@mansona mansona merged commit 6082c26 into layout May 26, 2025
4 checks passed
@mansona mansona deleted the remove-routes branch May 26, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants