docs: How do I "add ecad"? #1668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeAstapov
approved these changes
Apr 13, 2025
MichalBryxi
force-pushed
the
patch-2
branch
2 times, most recently
from
441e35e to
4362717
Compare
|
On hold until following are resolved: |
- Adding section does not have any isntructions. - Should I just `ember install`? Or are there any other steps?
|
@SergeAstapov Ready for discussion / merge |
|
Thank you @MichalBryxi! |
SergeAstapov
reviewed
May 2, 2025
| @@ -21,6 +21,8 @@ In my case, I did it as an [in repo addon](https://github.com/ember-animation/em | |||
|
|
|||
| ## 4. Add `ember-cli-addon-docs` to your docs app. | |||
|
|
|||
| You can follow the <DocsLink @route="quickstart">quickstart guide.</DocsLink> | |||
There was a problem hiding this comment.
@MichalBryxi looks like this didn't work actually, see https://ember-learn.github.io/ember-cli-addon-docs/versions/main/docs/standalone-apps
There was a problem hiding this comment.
Ah! Mea culpa. Fix: #1681
MichalBryxi
added a commit
to MichalBryxi/ember-cli-addon-docs
that referenced
this pull request
May 2, 2025
SergeAstapov
pushed a commit
that referenced
this pull request
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember install? Or are there any other steps?