Upgrade glimmer-vm #20842
Merged
Upgrade glimmer-vm #20842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… anymore (once built)
…ed to go bundle / rollup types in Glimmer
|
Progress |
NullVoxPopuli
added a commit
to glimmerjs/glimmer-vm
that referenced
this pull request
Feb 11, 2025
NullVoxPopuli
added a commit
to glimmerjs/glimmer-vm
that referenced
this pull request
Feb 11, 2025
This reverts commit b44b166.
…not needed, and is not public API -- it's compiled away during glimmer-vm publish
NullVoxPopuli
commented
Feb 12, 2025
| console.error(chalk.red(err.toString())); | ||
| console.error(chalk.red(`Error!`)); | ||
|
|
||
| if ('passed' in err) { |
There was a problem hiding this comment.
This change will print out:
{ passed: 40140, failed: 4, total: 40144, runtime: 47482 }
where as before it would print out [object Object]
ef4
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces: #20801
Warning
This requires we drop TS < 5, because we need
verbatimModuleSyntax. TS v5 came out in March of 2023, so folks have had plenty of time to move to a newer version (and this is even beyond the window of our Major release cadence, and I believe dropping this is fine, even though, we now require consumers useverbatimModuleSyntax.Most of what's in these VM changes is prep for bigger bugfixes and improvements (especially to debug tooling / inspector stuff).
The timing of this PR is early, as we don't want a big VM upgrade all at once.
Every change has gone through performance testing, and found either no regression, or slight improvement.
Changelog:
Updates:
notes:
long ago, I made https://github.com/NullVoxPopuli/tsc-lite because
tscdoes not the wrong thing by hiding your most important errors at the top of the buffer (and sometimes you have enough errors that it surpasses your max-buffer, so you can't scroll to the most important error). tsc-lite shows only the first few chunks of the tsc output, so you can focus on what to fix first, in the proper order.This has come in handy here, as we broke the types in glimmer-vm (they need to be rolled up).