-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Remove microtask in runtime compiler #20909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NullVoxPopuli
wants to merge
4
commits into
emberjs:main
Choose a base branch
from
NullVoxPopuli:nvp/remove-microtask-in-runtime-compiler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove microtask in runtime compiler #20909
NullVoxPopuli
wants to merge
4
commits into
emberjs:main
from
NullVoxPopuli:nvp/remove-microtask-in-runtime-compiler
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development AssetsDiff --- main/out.txt 2025-05-05 18:22:36.000000000 +0000
+++ pr/./pr-15003509554/out.txt 2025-05-13 18:01:50.000000000 +0000
@@ -1,5 +1,5 @@
2.2M └─┬ .
-1015K ├─┬ @ember
+1014K ├─┬ @ember
205K │ ├─┬ -internals
69K │ │ ├─┬ views
64K │ │ │ └─┬ lib Details
|
NullVoxPopuli
commented
May 12, 2025
@@ -242,12 +242,10 @@ export function template( | |||
const normalizedOptions = compileOptions(options); | |||
const component = normalizedOptions.component ?? templateOnly(); | |||
|
|||
queueMicrotask(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: for @NullVoxPopuli
- JS Representation of Template Tag rfcs#931
- does the RFC say anything about this?
Potential use case:
- forward references (like functions)
This test was presumably extracted from https://github.com/emberjs/ember.js/pull/20907/files wher eit makes sense. I'm replacing it with one that only covers the immediate change being made in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came out of