-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Remove microtask in runtime compiler #20909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove microtask in runtime compiler #20909
Conversation
Development AssetsDiff --- main/out.txt 2025-05-26 18:18:28.000000000 +0000
+++ pr/./pr-15475668273/out.txt 2025-06-05 19:34:46.000000000 +0000
@@ -1,5 +1,5 @@
2.2M └─┬ .
-1015K ├─┬ @ember
+1014K ├─┬ @ember
205K │ ├─┬ -internals
69K │ │ ├─┬ views
64K │ │ │ └─┬ lib Details
|
@@ -242,12 +242,10 @@ export function template( | |||
const normalizedOptions = compileOptions(options); | |||
const component = normalizedOptions.component ?? templateOnly(); | |||
|
|||
queueMicrotask(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: for @NullVoxPopuli
- JS Representation of Template Tag rfcs#931
- does the RFC say anything about this?
Potential use case:
- forward references (like functions)
This test was presumably extracted from https://github.com/emberjs/ember.js/pull/20907/files wher eit makes sense. I'm replacing it with one that only covers the immediate change being made in this PR.
|
fixed. Hoping we can merge soon, cause I really need |
Do we want to open another issue for this?
|
|
||
let state = new State(); | ||
|
||
hide(state); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ef4 Now we know hide
isn't just for eslint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think somewhere it was document (on hide maybe?) that this is for tricking JIT stuff
This came out of