Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nonetype check for videos, made url checks more general #15

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

emcf
Copy link
Owner

@emcf emcf commented Apr 29, 2024

Fixes #14 , additional fix for url matching, readme discord addition

@emcf emcf linked an issue Apr 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.93%. Comparing base (9276bbc) to head (39201e9).

Files Patch % Lines
thepipe_api/extractor.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   89.01%   88.93%   -0.09%     
==========================================
  Files           6        6              
  Lines         774      777       +3     
==========================================
+ Hits          689      691       +2     
- Misses         85       86       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emcf emcf merged commit 17323dd into main Apr 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some videos (without audio) fail to extract
1 participant