Skip to content

Enable Partial Measurements #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 16, 2025
Merged

Enable Partial Measurements #514

merged 15 commits into from
Apr 16, 2025

Conversation

Scienfitz
Copy link
Collaborator

@Scienfitz Scienfitz commented Mar 23, 2025

Enables partial measurements when composite surrogates and ParetoObjective are used.

  • Added method Campaign.update_measurements enabling the update of
    already existing measurements (should come in handy in pending
    measurement scenarios)
  • Target validation now allows NaNs
  • Minimal adjustments in pure and composite surrogates now either block
    NaNs (failing at recommendation attempt) or drop the corresponding rows when creating
    single-target surrogates (this is what enables partial measurements)
  • Added documentation mostly focused on the async workflows page

@Scienfitz Scienfitz added the new feature New functionality label Mar 23, 2025
@Scienfitz Scienfitz self-assigned this Mar 23, 2025
@Scienfitz Scienfitz marked this pull request as draft March 25, 2025 15:44
@Scienfitz Scienfitz force-pushed the feature/partial_measurements branch 3 times, most recently from 90fe6f0 to 5f099ec Compare April 6, 2025 18:11
@Scienfitz

This comment has been minimized.

@Scienfitz Scienfitz marked this pull request as ready for review April 6, 2025 18:59
@Scienfitz Scienfitz force-pushed the feature/partial_measurements branch 4 times, most recently from 69ee2b8 to bc7cfc5 Compare April 8, 2025 20:40
Copy link
Collaborator

@AdrianSosic AdrianSosic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks. A few things still need to be put into the right place before we can merge ...

@Scienfitz Scienfitz force-pushed the feature/partial_measurements branch from a821bf6 to 36c8e9e Compare April 11, 2025 14:55
@Scienfitz Scienfitz force-pushed the feature/partial_measurements branch from 0412263 to 11bf9d3 Compare April 15, 2025 14:41
Copy link
Collaborator

@AdrianSosic AdrianSosic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, great to have this feature. I think once the remaining open threads are resolved, this is ready for merge 👍🏼 🚀

@Scienfitz Scienfitz force-pushed the feature/partial_measurements branch from 9028bba to 98ac549 Compare April 15, 2025 20:16
@Scienfitz Scienfitz force-pushed the feature/partial_measurements branch from 98ac549 to 78d8032 Compare April 16, 2025 06:54
@Scienfitz Scienfitz merged commit a6938d6 into main Apr 16, 2025
16 of 22 checks passed
@Scienfitz Scienfitz deleted the feature/partial_measurements branch April 16, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants