Provide version fallback in case scm fails to infer version during installation #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scienfitz
reviewed
Apr 1, 2025
|
While I am at it - any hints on how to fix the Lockfiles-CI failure? |
In the specific case, baybe was installed format the git repository inside a docker container that did not provide the ` git` command, leading setuptools-scm to fail. Same happens if for any reason the .git directory is missing (e.g. when downloading a tarbal from github). The fallback version is set to `0.0+unknown` to ensure we adhere to PyPa (https://packaging.python.org/en/latest/specifications/version-specifiers/#examples-of-compliant-version-schemes ) while still ensuring any user will be able to recognize this as a non-standard version identifier.
dasmy
changed the title
Scienfitz
approved these changes
Apr 1, 2025
All good, you can ignore those. The LinAlgErrors keep sporadically showing up, we haven't found a reasonable fix yet. The lockfiles fail is just reminder to relock files in case dependencies have changed (is triggered whenever toml is touched – not ideal yet but fulfills its purpose) |
AdrianSosic
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix installation if setuptools-scm version inference fails.
In the specific case, baybe was installed format the git repository inside a docker container that did not provide the
gitcommand, leading setuptools-scm to fail. Same happens if for any reason the .git directory is missing (e.g. when downloading a tarbal from github).The fallback version is set to
0.0+unknownto ensure we adhere to PyPa (https://packaging.python.org/en/latest/specifications/version-specifiers/#examples-of-compliant-version-schemes) while still ensuring any user will be able to recognize this as a non-standard version identifier.Fixes #521