Introduce type parameter for plot points #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lucasmerlin @emilk could you have a look at it? |
emilk
reviewed
Jun 16, 2025
Comment on lines
+1131
to
+1132
| std::sync::Arc::new(egui::mutex::Mutex::new(std::collections::HashMap::< | ||
| Id, |
There was a problem hiding this comment.
Nit: this could use egui::IdMap (much faster)
| .collect::<Vec<_>>(); | ||
|
|
||
| let custom_things = | ||
| std::sync::Arc::new(egui::mutex::Mutex::new(std::collections::HashMap::< |
There was a problem hiding this comment.
Add some use statements to the top of this file so this becomes easier to read
| @@ -1101,6 +1107,61 @@ impl ChartsDemo { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(PartialEq, serde::Deserialize, serde::Serialize, Default)] | |||
| struct UserdataDemo {} | |||
There was a problem hiding this comment.
It's soon time to break up this file into several smaller files (not in this PR though!)
| @@ -409,7 +409,7 @@ impl<'a> Plot<'a> { | |||
| /// ``` | |||
| pub fn label_formatter( | |||
| mut self, | |||
| label_formatter: impl Fn(&str, &PlotPoint) -> String + 'a, | |||
| label_formatter: impl Fn(&str, &PlotPoint, Option<(Id, usize)>) -> String + 'a, | |||
There was a problem hiding this comment.
The docstring should explain what the third parameter is here
| struct DemoPoint { | ||
| x: f64, | ||
| y: f64, | ||
| custom_thing: bool, |
There was a problem hiding this comment.
This makes it sounds like some demo points has a custom thing, other don't. I think this feature deserves a more realistic example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening emilk/egui#4719