add layout to users/show view #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @shibby, Unfortunately, I couldn't understand the point of that changes. We provide user details via modal. Do we really need this or am I miss something? |
|
While i was using panel, it opened at new page, not in modal. I tought layout is forgotten. Thats why i sent this PR.
…Sent from my iPhone
On 7 Jan 2018, at 10:03, Emir Karşıyakalı ***@***.***> wrote:
Hello @shibby, Unfortunately, I couldn't understand the point of that changes. We provide user details via modal. Do we really need this or am I miss something?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Still, don't understand the issue. I am adding attachment below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.