Code

Address PR #9175 review comments#4

Code

Merged

emlun merged 15 commits intowebauthnemlun/syncthing:webauthnfrom webauthn-reviewemlun/syncthing:webauthn-reviewCopy head branch name to clipboardAug 11, 2024

+369-328

Commits

Commits on Aug 10, 2024

• Remove leftover WebAuthn state management from adjustConfig

  Show description for bd08cd9
  emlun

  committed
  bd08cd9

  Copy full SHA for bd08cd9

• Extract type webauthnLibUser to implement webauthnLib.User

  emlun

  committed
  c84ef05

  Copy full SHA for c84ef05

• Take GUIConfiguration parameter in IsAuthEnabled and IsAuthReady

  emlun

  committed
  0520acb

  Copy full SHA for 0520acb

• Make service.IsAuthEnabled private

  emlun

  committed
  afc7dd8

  Copy full SHA for afc7dd8

• Delete cfg and tokenCookieManager fields from webauthnService

  emlun

  committed
  aba1406

  Copy full SHA for aba1406

• Move tokenCookieManager and webauthnService back to Serve()

  emlun

  committed
  230f213

  Copy full SHA for 230f213

• Revert error result from api.New(...): Service

  emlun

  committed
  038627e

  Copy full SHA for 038627e

• Un-capitalize error messages

  emlun

  committed
  e908335

  Copy full SHA for e908335

Commits on Aug 11, 2024

• Add function structutil.WithDefaults

  emlun

  committed
  371ae5d

  Copy full SHA for 371ae5d

• Set default GUIConfiguration.WebauthnRpId and .WebauthnOrigin in tests

  emlun

  committed
  38fb26c

  Copy full SHA for 38fb26c

• Remove default rpId in EligibleWebAuthnCredentials

  emlun

  committed
  328eb68

  Copy full SHA for 328eb68

• Remove default reflection from newWebauthnEngine

  emlun

  committed
  fa16d27

  Copy full SHA for fa16d27

• Delete unused receiver

  emlun

  committed
  a606a47

  Copy full SHA for a606a47

• Use short device ID instead of device name in WebAuthn RP display name

  Show description for 6ddf7a8
  emlun

  committed
  6ddf7a8

  Copy full SHA for 6ddf7a8

• Clarify behaviour of structutil.SetDefaults in doc comment

  emlun

  committed
  877f43d

  Copy full SHA for 877f43d