-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pbranch #35
Merged
Merged
Pbranch #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
emmanueposu
commented
May 30, 2024
•
edited
Loading
edited
- Added loading spinner to MyTrivia page.
- Removed loading spinner for game slideshow. Optimized the algorithm for retrieving game info so loading spinner is no longer needed.
- Removed login modal and changed login button to redirect to login page.
- Made login and signup button on home page unavailable when user is logged in.
- Removed outdated comments and unused imports statements from various files.
- Fixed issue where user can log in with invalid credentials.
- Disabled the generate button on the Create New Trivia page for users not logged in. Added a tooltip that tells users to login if they want to create a game.
- Added a link to display on MyTrivia page that redirects to TriviaGenPage if there are no games to display
- Updated project’s file and folder names to follow consistent naming conventions
- Updated AddAllForGame function to return game with details and changed loaded from a local to a global state. Now the getGamesWithDetails function on the myTriviaPage only needs to be called once, instead of every time a game is added and/or page refresh.
- Updated project’s files to follow consistent spacing and removed unused variables
…age if there are no games to display
…d loaded from a local to a global state
justinstoner2
approved these changes
Jun 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.