Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pbranch #35

Merged
merged 12 commits into from
Jun 1, 2024
Merged

Pbranch #35

merged 12 commits into from
Jun 1, 2024

Conversation

emmanueposu
Copy link
Owner

@emmanueposu emmanueposu commented May 30, 2024

  • Added loading spinner to MyTrivia page.
  • Removed loading spinner for game slideshow. Optimized the algorithm for retrieving game info so loading spinner is no longer needed.
  • Removed login modal and changed login button to redirect to login page.
  • Made login and signup button on home page unavailable when user is logged in.
  • Removed outdated comments and unused imports statements from various files.
  • Fixed issue where user can log in with invalid credentials.
  • Disabled the generate button on the Create New Trivia page for users not logged in. Added a tooltip that tells users to login if they want to create a game.
  • Added a link to display on MyTrivia page that redirects to TriviaGenPage if there are no games to display
  • Updated project’s file and folder names to follow consistent naming conventions
  • Updated AddAllForGame function to return game with details and changed loaded from a local to a global state. Now the getGamesWithDetails function on the myTriviaPage only needs to be called once, instead of every time a game is added and/or page refresh.
  • Updated project’s files to follow consistent spacing and removed unused variables

Copy link
Collaborator

@justinstoner2 justinstoner2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@justinstoner2 justinstoner2 merged commit 7f6ecdd into main Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants