Proxy process exit from pthread to main thread using a postMessage() #25048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juj
force-pushed
the
fix_flaky_test_pthread_print_override_modularize
branch
from
d6162c2 to
17dabaa
Compare
…and not the WebAssembly heap-based proxying queue, so that all postMessage()s will flush in-order before the process exit command does. Fixes other.test_pthread_print_override_modularize flakiness.
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (2) test expectation files were updated by running the tests with `--rebaseline`: ``` code_size/test_codesize_minimal_pthreads.json: 27237 => 27226 [-11 bytes / -0.04%] code_size/test_codesize_minimal_pthreads_memgrowth.json: 27665 => 27654 [-11 bytes / -0.04%] Average change: -0.04% (-0.04% - -0.04%) ```
juj
force-pushed
the
fix_flaky_test_pthread_print_override_modularize
branch
from
d96e783 to
878a6e8
Compare
…d_print_override_modularize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxy process exit from pthread to main thread using a postMessage() and not the WebAssembly heap-based proxying queue, so that all postMessage()s will flush in-order before the process exit command does.
Fixes
other.test_pthread_print_override_modularizeflakiness.There the problem was that a pthread performs a print, which is proxied over to the main thread using a
printcallHandler.Then pthread quits, which would result in
exitOnMainThreadbeing called, but that would utilize the WebAssembly heap based proxying queue.On the main thread then depending on the phase of the moon, the main thread will either flush the Wasm heap queue or the postMessage() queue first.
By
postMessage()ing also the process exit call, then we can ensure that all previous postMessage()s, such as the print() call, will be flushed sequentially before the process exit call is processed.