Remove the wasm-instantate run dependency. NFC
#25096
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead we can just delay the `run` call until after createWasm is resolved. This results in a nice code size saving.
kripken
reviewed
Aug 28, 2025
| #else | ||
| // With async instantation wasmExports is assigned asynchronously when the | ||
| // instance is received. | ||
| createWasm(); | ||
| createWasm().then(() => run()); |
There was a problem hiding this comment.
IIUC this will delay preRun (including preloading data files) until the wasm is ready, but I think before we could do them in parallel?
There was a problem hiding this comment.
Maybe, but we already that just above where we await createWasm. I will check..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead we can just delay the
runcall until after the async createWasm function returns/resolves.This results in a nice code size saving.