-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Fix regression in unique_together
validation with SerializerMethodField
#9712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
While building validator unique together fields were compared with declared field names instead of model field names
It also possible to unify code related to django-rest-framework/rest_framework/serializers.py Lines 1600 to 1604 in 33d59fe
django-rest-framework/rest_framework/serializers.py Lines 1475 to 1478 in 33d59fe
|
you can come with the unified code for review as well |
unique_together
validation with SerializerMethodField
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my perspective, I'm happy to get it merge this as is. Thanks for picking it up
While building validator unique together fields were compared with declared field names instead of model field names
fixes #9700
closes #9710