Misc fixes ahead of push to beta classification #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standardize language in logging messages Move system version to constants Fixes #3
When running 'poetry remove tox-poetry-installer' in the same env as poetry is installed to, poetry will uninstall itself. This is, obviously, not ideal. This change makes poetry an optional dependency so that the plugin can be installed (and uninstalled) alongside poetry in the same env without breaking the poetry installation. The intention is that the plugin can be installed with the 'poetry' extra when being installed to an isolated environment where poetry is not otherwise available. This is a mitigation of Issue #2 as an alternative to vendorization of the enitre poetry project 😬
… envs Add the _poetry submodule to support importing Poetry internals at runtime rather than import time. This allows the plugin to be run, and either skipped or errored, without crashing tox
enpaul
force-pushed
the
enp/cleanup
branch
4 times, most recently
from
3802af8 to
be4331b
Compare
enpaul
force-pushed
the
enp/cleanup
branch
3 times, most recently
from
16debea to
ea9a6b6
Compare
Add caching for pip and poetry downloads to reduce runtime Add pinned pip version Add poetry installation of local project Remove bare pip install for local project installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poetrydependency to be optionally installed with the[poetry]extra to support parallel installation to the main Poetry environment