tooling: Add docker build util #17384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repokitteh-read-only
bot
added
the
deps
phlax
force-pushed
the
dist-add-docker-utils
branch
from
5131b35
to
afed5d4
Compare
|
coverage is here https://storage.googleapis.com/envoy-pr/17384/tooling/index.html |
phlax
force-pushed
the
dist-add-docker-utils
branch
2 times, most recently
from
1110d80
to
b66ecbe
Compare
phlax
changed the title
phlax
commented
Jul 16, 2021
|
related - i have opened a ticket upstream aio-libs/aiodocker#602 with an offer to add a util which could simplify this code a bit |
phlax
force-pushed
the
dist-add-docker-utils
branch
6 times, most recently
from
4eb6542
to
c4009d5
Compare
phlax
commented
Jul 19, 2021
phlax
changed the title
phlax
force-pushed
the
dist-add-docker-utils
branch
from
c4009d5
to
3191706
Compare
phlax
changed the title
phlax
force-pushed
the
dist-add-docker-utils
branch
2 times, most recently
from
dbd0127
to
7f53ea9
Compare
Signed-off-by: Ryan Northey <[email protected]>
phlax
force-pushed
the
dist-add-docker-utils
branch
from
7f53ea9
to
aa1694e
Compare
|
WIPping this as im thinking about an implementation where its not currently required. |
phlax
changed the title
phlax
changed the title
|
after a bit of further testing i realised this would increase the complexity as it would require build a volume for the artefacts |
mattklein123
approved these changes
Jul 20, 2021
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: Ryan Northey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey [email protected]
Commit Message:
adds a util to build docker images using
aiodockerwith a full build contextAdditional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]