Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: removes 'wip' from dynamic_modules #38956

Merged
merged 3 commits into from
Mar 31, 2025
Merged

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Mar 28, 2025

Commit Message: api: removes 'wip' from dynamic_modules
Additional Description:

The dynamic modules API was introduced 6 months ago in #36448 and at the time we didn't have either an implementation or confidence on the configuration API, so it has been marked WIP just in case.

Now that the initial implementation is done, and the documentation as well as the example repository is hosted at envoyproxy/dynamic-modules-examples, early adopters have already tried it out and we haven't heard any concern about the configuration API, so this commit removes the WIP marker towards the next release of Envoy v1.34.

Note that the extension itself is still in alpha, it follows the same caveat like any other alpha extensions.

Risk Level: low
Testing: existing tests.
Docs Changes: Already done in the past commits
Release Notes: Already done in the past commits
Platform Specific Features: n/a

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #38956 was opened by mathetake.

see: more, trace.

Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #38956 was opened by mathetake.

see: more, trace.

@mathetake mathetake marked this pull request as ready for review March 28, 2025 16:40
@mathetake
Copy link
Member Author

oh sorry format

Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this change. Happy to see dynamic module become more and more mature.

@wbpcode wbpcode merged commit ed3b31b into envoyproxy:main Mar 31, 2025
25 checks passed
@mathetake mathetake deleted the removewip branch March 31, 2025 14:26
mathetake added a commit to envoyproxy/dynamic-modules-examples that referenced this pull request Mar 31, 2025
The API is now not WIP! envoyproxy/envoy#38956

Signed-off-by: Takeshi Yoneda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants