Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth2: remove OAUTH_NONCE build trail dead code #38965

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

botengyao
Copy link
Member

@botengyao botengyao commented Mar 29, 2025

it is clear that it is a dead&wrong code, and the oauth_nonce is only used in redirectToOAuthServer

Commit Message:
Additional Description:
Risk Level: low
Fixes:#38799
Testing:
Docs Changes:
Release Notes:

Signed-off-by: Boteng Yao <boteng@google.com>
@botengyao botengyao merged commit 8566217 into envoyproxy:main Mar 31, 2025
24 checks passed
@botengyao botengyao deleted the oauth2_dead_code branch March 31, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants