#5700 - System allow to establish infinit number of bonds from monomer to microstructure #6225
+15
−368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from the same attachment point
lmhs
force-pushed
the
5700-system-allow-to-establish-infinit-number-of-bonds-from-monomer-to-microstructure
branch
from
ccf6c86 to
a3b77a3
Compare
auto-assign
bot
requested review from
AlexeyGirin,
NataliaLoginova and
rrodionov91
lmhs
force-pushed
the
5700-system-allow-to-establish-infinit-number-of-bonds-from-monomer-to-microstructure
branch
2 times, most recently
from
b13671d to
232ce4d
Compare
…ber-of-bonds-from-monomer-to-microstructure
…o-establish-infinit-number-of-bonds-from-monomer-to-microstructure
…lish-infinit-number-of-bonds-from-monomer-to-microstructure
TODO: allow bond creation using only attachment points
NataliaLoginova
approved these changes
Feb 16, 2025
added 3 commits
February 17, 2025 12:57
…ber-of-bonds-from-monomer-to-microstructure
…ber-of-bonds-from-monomer-to-microstructure
rrodionov91
requested changes
Feb 18, 2025
| @@ -465,21 +466,36 @@ class PolymerBond implements BaseTool { | |||
|
|
|||
| const atomRenderer = event.target.__data__ as AtomRenderer; | |||
| const monomer = this.bondRenderer?.polymerBond.firstMonomer; | |||
|
|
|||
| if ( | |||
| monomer instanceof Chem && | |||
There was a problem hiding this comment.
Please delete monomer instanceof Chem && because restriction should work for all types of monomers
There was a problem hiding this comment.
I saw the description.
I'm 100% sure that it should work for every type of monomer. Discussed with @AlexeyGirin one more time, he approved. Please remove the line.
...sts/tests/Macromolecule-editor/Polymer-Bond-Tool/connection-rules-for-chems-monomers.spec.ts
Show resolved
Hide resolved
lmhs
commented
Feb 19, 2025
rrodionov91
approved these changes
Feb 20, 2025
rrodionov91
deleted the
5700-system-allow-to-establish-infinit-number-of-bonds-from-monomer-to-microstructure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
Following the proposal by @tanas80 and further discussion with @AlexeyGirin and @ljubica-milovic it was approved that to resolve issue #5700 creation of non-hydrogen bond from center of the CHEM monomer must be forbidden with notification banner displayed if bond target is Atom, only attachment points can be used for creating bonds from CHEM monomer to Atoms
Fixes #5700
Check list
#1234 – issue name