Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mgm/respect stereo center option #6378

Conversation

martinuncountable
Copy link

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

martinuncountable and others added 30 commits June 8, 2023 11:29
…hema

replace ajv with jsonschema library
use alias plugin to resolve native url
…-container

Mgm/fix mouse inside other container
@svvald
Copy link
Collaborator

svvald commented Feb 24, 2025

Hi @martinuncountable,

Thank you for your contribution! We truly appreciate the time and effort you've put into maintaining your Ketcher fork. I assume this pull request is intended to synchronize your changes with the upstream?

Unfortunately, we can’t merge it as is. There are a few key challenges:

  • Merge conflicts – The PR contains multiple conflicts that need to be resolved.
  • Contradictions with recent upstream changes – Some of your modifications conflict with updates that have been made in the upstream repository (e.g., integrating json-schema is unnecessary since we're using a pre-compiled schema with ajv, as covered in PR #6269).
  • Scope and context – The PR introduces a large number of changes without enough context, making it difficult to fully understand the original issues being addressed and the expected outcomes.

To make the review process smoother and increase the chances of merging your contributions quickly, I’d suggest breaking this PR into smaller, focused changes. Specifically, it would be great if you could:

  • Create separate GitHub issues for each distinct problem or use case you aimed to solve.
  • Submit individual pull requests addressing each issue, prioritizing the most important ones for you.

This approach will help us review and merge relevant changes much faster, potentially getting them into upcoming releases. Let us know if you need any guidance on structuring the issues or PRs – we’d be happy to help!

Looking forward to working through this together.

@martinuncountable
Copy link
Author

Hi @martinuncountable,

Thank you for your contribution! We truly appreciate the time and effort you've put into maintaining your Ketcher fork. I assume this pull request is intended to synchronize your changes with the upstream?

Unfortunately, we can’t merge it as is. There are a few key challenges:

* **Merge conflicts** – The PR contains multiple conflicts that need to be resolved.

* **Contradictions with recent upstream changes** – Some of your modifications conflict with updates that have been made in the upstream repository (e.g., integrating json-schema is unnecessary since we're using a pre-compiled schema with ajv, as covered in [PR #6269](https://github.com/epam/ketcher/pull/6269)).

* **Scope and context** – The PR introduces a large number of changes without enough context, making it difficult to fully understand the original issues being addressed and the expected outcomes.

To make the review process smoother and increase the chances of merging your contributions quickly, I’d suggest breaking this PR into smaller, focused changes. Specifically, it would be great if you could:

* Create **separate GitHub issues** for each distinct problem or use case you aimed to solve.

* Submit **individual pull requests** addressing each issue, prioritizing the most important ones for you.

This approach will help us review and merge relevant changes much faster, potentially getting them into upcoming releases. Let us know if you need any guidance on structuring the issues or PRs – we’d be happy to help!

Looking forward to working through this together.

@svvald I meant to open this against the fork we have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.