fix: layout shift caused by Dropdownmenu and make it to a separate component #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
requested changes
Jan 17, 2025
package.json
Outdated
Comment on lines
7
to
8
| "head": "5c5328b38e442d78933d5be8fae21fe317296c29", | ||
| "date": "2025-01-17T19:16:26Z" | ||
| "head": "8468b0101fbee9d09f7ea426eaefec74583641b4", | ||
| "date": "2025-01-17T20:19:33Z" |
There was a problem hiding this comment.
Could you undo this change? Just leave out the package.json from the changes.
rajeshg
force-pushed
the
main
branch
2 times, most recently
from
5dfde4f to
8468b01
Compare
Yes. Looks good to me. Tested from Windows env |
|
Thanks! |
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User drop down menu causes a horizontal layout shift (see shadcn-ui/ui#977)
Also refactored UserDropdown to it's own component similar to SearchBar
Test Plan
Checklist
Screenshots