-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 13: Update GitHub actions #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bbc7607.
athowes
added
active
PRs that are being actively worked on
and removed
soft block
PRs that are softly blocked
labels
Jun 13, 2024
seabbs
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
seabbs
pushed a commit
that referenced
this pull request
Jan 10, 2025
* Remove master and develop branch mentions * Add default touchstone set-up * Revert "Add default touchstone set-up" This reverts commit bbc7607. Former-commit-id: 671278dcc1637276b28692cac053eec45de20821 [formerly f4908a9678220fa0552400db227077191884b59e] Former-commit-id: 9c67e598ab2a0f7e82108c58d3a3fd36297fed59
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Remove master and develop branch mentions * Add default touchstone set-up * Revert "Add default touchstone set-up" This reverts commit bbc7607. Former-commit-id: 671278dcc1637276b28692cac053eec45de20821 [formerly f4908a9678220fa0552400db227077191884b59e] Former-commit-id: 9c67e598ab2a0f7e82108c58d3a3fd36297fed59
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Remove master and develop branch mentions * Add default touchstone set-up * Revert "Add default touchstone set-up" This reverts commit bbc7607. Former-commit-id: 671278dcc1637276b28692cac053eec45de20821 [formerly f4908a9678220fa0552400db227077191884b59e] Former-commit-id: 9c67e598ab2a0f7e82108c58d3a3fd36297fed59 Former-commit-id: 69769fc
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Remove master and develop branch mentions * Add default touchstone set-up * Revert "Add default touchstone set-up" This reverts commit bbc7607. Former-commit-id: 3a4162b Former-commit-id: 65a6edd82d49650bf3b0468b1cad58fa61609237 Former-commit-id: 92f3c079df4ec36c0aee64b0a3838fdc2ae8f121 [formerly 695bd12] Former-commit-id: f68f7491ae56c8587206a024981dfcb60ee17815
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Remove master and develop branch mentions * Add default touchstone set-up * Revert "Add default touchstone set-up" This reverts commit bbc7607. Former-commit-id: 3a4162b Former-commit-id: 65a6edd82d49650bf3b0468b1cad58fa61609237 Former-commit-id: 92f3c079df4ec36c0aee64b0a3838fdc2ae8f121 [formerly 695bd12] Former-commit-id: f68f7491ae56c8587206a024981dfcb60ee17815
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Sam writes that we likely want GitHub actions to:
pkgdown
R CMD CHECK
against multiple OS's*lintr
codecov
cmdstanr
code works with the latest version ofcmdstanr
(optional / stretch goal)touchstone
(also a stretch goal / its own issue).*if we have things in our tests we don't expect to run on CRAN then we might also way two versions of this [i.e with and without those tests being skipped]
Also noting that:
epinowcast
and so in the first instance we can mostly just copy them across and read through them to check there is nothing specific toepinowcast
in them.R CMD CHECK
currently we expect those to fail but a focus early in the development should be to get the code base (via cutting and documentation etc) to a place where those both pass. This should really be done ahead of adding in new features, making interface changes, or adding lots of tests in my view. The other critical CI we need in place before adding tests is code coverage as that will help us when building out the testing suite.Changes
So far the changes made have been:
master
anddevelop
branches (we are not using these)I have also written where I think things are completed already in the table above.
In doing so, this PR closes #13.
Checklist