Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Home Collection Print Address code to account for updates to address in User Profile (Biospecimen) #1174

Closed
erincschwartz opened this issue Dec 16, 2024 · 7 comments
Assignees
Labels
CCC Priority 1 Issues to be addressed in the current release

Comments

@erincschwartz
Copy link
Collaborator

Update the Home Collection Print Address code to take into account these additions to the User Profile, expected in January 2025 release:

  1. A field for Physical Address
  2. A checkbox for people to indicate if the Mailing Address (what we currently capture) is a PO Box
@erincschwartz erincschwartz converted this from a draft issue Dec 16, 2024
@sonyekere sonyekere added CCC Backlog CCC Priority 2 Issues will be prioritized in the upcoming/next release and removed CCC Backlog labels Dec 16, 2024
@sonyekere
Copy link
Collaborator

This will be looked into in the Jan release

@sonyekere sonyekere moved this from Backlog to Development in Connect Development and Support Dec 17, 2024
@Davinkjohnson
Copy link
Collaborator

DevOps will need clear requirements on what should be done to account for the items mentioned in the original comment. Should label use physical address if present, what should be done if the checkbox was selected for PO Box? etc.

@jhflorey jhflorey moved this from Development to Backlog in Connect Development and Support Dec 31, 2024
@sonyekere sonyekere added CCC Priority 1 Issues to be addressed in the current release and removed CCC Priority 2 Issues will be prioritized in the upcoming/next release labels Jan 2, 2025
@erincschwartz
Copy link
Collaborator Author

Requirements based on User Profile updates:

  • If physical address is provided, use this for mouthwash kit address
  • If no physical address is provided, use mailing address
  • Continue running the existing screening formula to check for P.O. Box addresses, with additional check of the checkbox for "Mailing address is a PO Box," if this checkbox is filled in, do not include this participant in the Print Address list
  • Apply P.O. Box screening formula to Physical Address fields
  • Always use current address, ignore User Profile history

@sonyekere sonyekere moved this from Backlog to Development in Connect Development and Support Jan 7, 2025
@amber-emmes
Copy link
Collaborator

Implementation question: for the purposes of the totalAddressesToPrint and getElgiblePtsForAssignment endpoints, do we want the physicalAddress to take the place of all corresponding address values if the address is a P.O. Box? Is that the same whether it's marked as a P.O. Box and whether it's not marked as a P.O. Box but is identified as a P.O. Box by our P.O. Box identification logic?

@brotzmanmj
Copy link
Collaborator

I would say yes

@amber-emmes
Copy link
Collaborator

This is now ready to test in dev.

@erincschwartz
Copy link
Collaborator Author

@amber-emmes, if there is a physical address, that should be used, regardless if mailing address is PO box or the check box for PO box is marked. Testing revealed that this is not functioning as expected.

  • Tested with Connect ID 3336822035, entered mailing address (Townview Ave) and physical address (Smith Ave) into User Profile (left the check for PO Box unchecked)
  • Address in the MW address file is mailing address

Also, if Physical address is a P.O. Box, how would current programming handle this? Would the participant be left off the MW address list? Would the programming check for mailing address?

In this case, if physical address is PO Box, we do want the program to check properties of the mailing address. If that also meets the definition of PO Box and/or if the check box for PO box is marked, then the participant should be excluded from the MW address list.

@amber-emmes
Copy link
Collaborator

if there is a physical address, that should be used, regardless if mailing address is PO box or the check box for PO box is marked. Testing revealed that this is not functioning as expected.

Ah, I misunderstood that; I thought we wanted mailing address to be the default address for, er, mailing, so long as it wasn't a PO box. I'll update and submit a new PR.

Also, if Physical address is a P.O. Box, how would current programming handle this? Would the participant be left off the MW address list? Would the programming check for mailing address?

The current programming checks if the physical address is a PO box according to the same way that mailing address was previously checked, and leaves it off of the home MW list if it is. I will update it to check if the physical address is a PO Box first and then check the mailing address.

@amber-emmes
Copy link
Collaborator

This should now be updated in dev; please re-review.

@erincschwartz
Copy link
Collaborator Author

erincschwartz commented Jan 24, 2025

Re-tested in Dev, ready for Stage.

Scenarios tested:

• If physical address is provided, always use this address (unless it is PO Box)
Physical address appeared in MW Address file, as expected

• If no physical address is provided, use mailing address
Only mailing address present
Mailing address appeared in MW Address file, as expected

• If physical address is PO box, use mailing address
Physical address: P.O. Box ####
Mailing address appeared in MW Address file, as expected

• If physical address is PO box and “Check for PO Box” is checked under mailing address, do not include in list
Physical address is PO box and even though mailing address was not a PO box, the box was checked
Participant did not appear on MW address list, as expected

• Always use current address, ignore User Profile history
Connect ID 5048067057
Mailing address entered and updated
Address in MW Address list is address currently showing in Participant Details, as expected

• If both physical address and mailing address are PO boxes, do not include in address list
Participant did not appear on MW address list, as expected

• No physical address, mailing address is PO Box, checkbox for PO box address is not marked
Participant did not appear on MW address list, as expected

@erincschwartz
Copy link
Collaborator Author

Tested in Stage, ready for Prod.

• If physical address is provided, always use this address (unless it is PO Box)
Physical address appeared in MW file, as expected

• If no physical address is provided, use mailing address
Only mailing address present
Mailing address appeared in MW file, as expected

• If physical address is PO box, use mailing address
Mailing address appeared in MW file, as expected

• If physical address is PO box and “Check for PO Box” is checked under mailing address, do not include in list
Physical address is PO box and even though mailing address was not a PO box, the box was checked
Participant is not on mailing list, as expected

• Make sure historical addresses are not being used
New mailing address appeared in MW file, as expected

• If both physical address and mailing address are PO boxes, do not include in address list
Participant is not on mailing list, as expected

• No physical address, mailing address is PO Box, checkbox for PO box address is not marked
Participant is not on mailing list, as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCC Priority 1 Issues to be addressed in the current release
Projects
Development

No branches or pull requests

6 participants