-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Home Collection Print Address code to account for updates to address in User Profile (Biospecimen) #1174
Comments
This will be looked into in the Jan release |
DevOps will need clear requirements on what should be done to account for the items mentioned in the original comment. Should label use physical address if present, what should be done if the checkbox was selected for PO Box? etc. |
Requirements based on User Profile updates:
|
Implementation question: for the purposes of the |
I would say yes |
This is now ready to test in dev. |
@amber-emmes, if there is a physical address, that should be used, regardless if mailing address is PO box or the check box for PO box is marked. Testing revealed that this is not functioning as expected.
Also, if Physical address is a P.O. Box, how would current programming handle this? Would the participant be left off the MW address list? Would the programming check for mailing address? In this case, if physical address is PO Box, we do want the program to check properties of the mailing address. If that also meets the definition of PO Box and/or if the check box for PO box is marked, then the participant should be excluded from the MW address list. |
Ah, I misunderstood that; I thought we wanted mailing address to be the default address for, er, mailing, so long as it wasn't a PO box. I'll update and submit a new PR.
The current programming checks if the physical address is a PO box according to the same way that mailing address was previously checked, and leaves it off of the home MW list if it is. I will update it to check if the physical address is a PO Box first and then check the mailing address. |
This should now be updated in dev; please re-review. |
Re-tested in Dev, ready for Stage. Scenarios tested: • If physical address is provided, always use this address (unless it is PO Box) • If no physical address is provided, use mailing address • If physical address is PO box, use mailing address • If physical address is PO box and “Check for PO Box” is checked under mailing address, do not include in list • Always use current address, ignore User Profile history • If both physical address and mailing address are PO boxes, do not include in address list • No physical address, mailing address is PO Box, checkbox for PO box address is not marked |
Tested in Stage, ready for Prod. • If physical address is provided, always use this address (unless it is PO Box) • If no physical address is provided, use mailing address • If physical address is PO box, use mailing address • If physical address is PO box and “Check for PO Box” is checked under mailing address, do not include in list • Make sure historical addresses are not being used • If both physical address and mailing address are PO boxes, do not include in address list • No physical address, mailing address is PO Box, checkbox for PO box address is not marked |
Update the Home Collection Print Address code to take into account these additions to the User Profile, expected in January 2025 release:
The text was updated successfully, but these errors were encountered: