Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State diff sync #1838

Merged
merged 23 commits into from
Mar 11, 2024
Merged

State diff sync #1838

merged 23 commits into from
Mar 11, 2024

Conversation

CHr15F0x
Copy link
Member

@CHr15F0x CHr15F0x commented Mar 5, 2024

Fixes #1704

@CHr15F0x CHr15F0x force-pushed the chris/p2p-sync-state-diff branch 5 times, most recently from cddee93 to 0e71658 Compare March 5, 2024 13:43
@CHr15F0x CHr15F0x marked this pull request as ready for review March 5, 2024 13:55
@CHr15F0x CHr15F0x requested a review from a team as a code owner March 5, 2024 13:55
sistemd
sistemd reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@sistemd sistemd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the one comment above.

Mirko-von-Leipzig
Mirko-von-Leipzig reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid foundation; some questions / options - which don't necessarily have to be applied right now. But at minimum I would strongly consider splitting the state trie updates into a separate PR / sync stage.

crates/ethereum/src/lib.rs Outdated Show resolved Hide resolved
crates/common/src/state_update.rs Outdated Show resolved Hide resolved
crates/p2p/src/client/peer_agnostic.rs Outdated Show resolved Hide resolved
crates/storage/src/fake.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
crates/pathfinder/src/sync/p2p/headers.rs Outdated Show resolved Hide resolved
crates/pathfinder/src/sync/p2p.rs Outdated Show resolved Hide resolved
crates/pathfinder/src/sync/p2p.rs Show resolved Hide resolved
crates/p2p/src/client/peer_agnostic.rs Outdated Show resolved Hide resolved
crates/pathfinder/src/sync/p2p/state_updates.rs Show resolved Hide resolved
@CHr15F0x CHr15F0x force-pushed the chris/p2p-sync-state-diff branch 5 times, most recently from dfed3b0 to 50ced3f Compare March 7, 2024 09:46
Mirko-von-Leipzig
Mirko-von-Leipzig approved these changes Mar 8, 2024
View reviewed changes
crates/pathfinder/src/state/sync.rs Outdated Show resolved Hide resolved
@CHr15F0x CHr15F0x force-pushed the chris/p2p-sync-state-diff branch 3 times, most recently from 6f5ea9c to 8a6ce97 Compare March 8, 2024 15:39
CHr15F0x and others added 15 commits March 11, 2024 10:35
@CHr15F0x
refactor(sync/p2p): minor renames
94d5538
@CHr15F0x
chore: clippy'n'co
7e70fe4
@CHr15F0x
doc: remove invalid comment
30f6df9
@CHr15F0x
doc: remove invalid comment
e2a6eb9
@CHr15F0x
feat(sync/p2p): drive stream to completion
db694e7
@CHr15F0x
fix(sync/p2p): invalid Fin handing and endless loop
acd29d5
@CHr15F0x
fix(sync/p2p): remove state trie update from sync
02f0858
@CHr15F0x @Mirko-von-Leipzig
refactor(sync/p2p): renames, remove Copy
60ce408 
Co-authored-by: Mirko von Leipzig <[email protected]>
@CHr15F0x
refactor(storage): merge counters with headers table
175dfee
@CHr15F0x
fix(storage): migrate past blocks
9fd7d3b
@CHr15F0x
fix(sync): gw sync does not fill state update counts
b05b9f6
@CHr15F0x
refactor(state_update): extract counts in a method
6554683
@CHr15F0x
refactor(storage): counts getter should not wrap in Option
643f8e5
@CHr15F0x
fix(p2p): contract update stream terminates immediately if start>stop
56b369c
@CHr15F0x
fix(p2p): loop on state_updates::next_missing in state update sync
314b5f9
@CHr15F0x CHr15F0x force-pushed the chris/p2p-sync-state-diff branch from 3223b09 to 314b5f9 Compare March 11, 2024 09:52
This was referenced Mar 11, 2024
Closed
Closed
@CHr15F0x
Copy link
Member Author

Follow up issues are gathered in #1855

@CHr15F0x CHr15F0x merged commit 46b2c27 into main Mar 11, 2024
7 checks passed
@CHr15F0x CHr15F0x deleted the chris/p2p-sync-state-diff branch March 11, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sistemd sistemd sistemd approved these changes

@Mirko-von-Leipzig Mirko-von-Leipzig Mirko-von-Leipzig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

p2p: implement state diff sync
3 participants
@CHr15F0x @sistemd @Mirko-von-Leipzig