Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc/v06): Core transaction methods/types #2550

Merged
merged 1 commit into from
Feb 4, 2025
Merged

feat(rpc/v06): Core transaction methods/types #2550

merged 1 commit into from
Feb 4, 2025
+90 −13

Conversation

t00ts
Copy link
Contributor

@t00ts t00ts commented Jan 31, 2025 •
edited
Loading

Re-introduce v06 JSON RPC methods:

  • starknet_estimateFee
  • starknet_getTransactionStatus
  • starknet_getTransactionReceipt

See also #2514

@t00ts t00ts force-pushed the shared/rpc-reintroduce-v06 branch from 1ea51d3 to 7572d70 Compare January 31, 2025 09:55
Base automatically changed from shared/rpc-reintroduce-v06 to main January 31, 2025 10:12
@vbar vbar mentioned this pull request Feb 3, 2025
Merged
@t00ts t00ts force-pushed the t00ts/rpc-v06-core-tx branch from 91cb4ba to f10df77 Compare February 3, 2025 14:52
@t00ts
feat(rpc/v06): restore starknet_estimateFee, `starknet_getTransacti…
b24578b 
…onStatus`, `starknet_getTransactionReceipt`
@t00ts t00ts force-pushed the t00ts/rpc-v06-core-tx branch from f10df77 to b24578b Compare February 4, 2025 04:55
@t00ts t00ts marked this pull request as ready for review February 4, 2025 04:59
@t00ts t00ts requested a review from a team as a code owner February 4, 2025 04:59
kkovaacs
kkovaacs approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@kkovaacs kkovaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@t00ts t00ts merged commit 24c1ef3 into main Feb 4, 2025
8 checks passed
@t00ts t00ts deleted the t00ts/rpc-v06-core-tx branch February 4, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkovaacs kkovaacs kkovaacs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t00ts @kkovaacs