Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): re-enable route tests for v06 #2557

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

kkovaacs
Copy link
Contributor

And fix tests for the root to use the default (v07) API.

I've left the websocket-specific tests commented out for now, since that would require duplicating the list of exemptions -- we should re-add those when we have all the methods we want properly registered/working.

@kkovaacs kkovaacs requested a review from a team as a code owner January 31, 2025 12:11
And fix tests for the root to use the default (v07) API.
@kkovaacs kkovaacs force-pushed the krisztian/rpc-0.6-re-add-route-tests branch from c30ad15 to 7029aeb Compare January 31, 2025 12:31
Copy link
Contributor

@t00ts t00ts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Those v06 root tests probably my bad from the refactor days, thnx!

@kkovaacs kkovaacs merged commit c148f04 into main Jan 31, 2025
7 of 8 checks passed
@kkovaacs kkovaacs deleted the krisztian/rpc-0.6-re-add-route-tests branch January 31, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants