feat(rpc/v06): re-add starknet_getEvents and starknet_getStateUpdate
#2563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pending state updates are missing _both_ `block_hash` and `new_root`, so both the test input and the expected output should reflect that.
Both of these methods are identical across all of our supported JSON-RPC versions, and JSON-RPC 0.6.0 is also the same.
kkovaacs
force-pushed
the
krisztian/rpc-0.6-re-add-events-and-state-update
branch
from
aa7f96e to
0fb4c25
Compare
vbar
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of these methods are identical across all of our supported JSON-RPC versions, and JSON-RPC 0.6.0 is also the same.
In addition, I found a test case that was inconsistent with the OpenRPC specification for state updates -- that should be also fixed.