Replace old GENERAL_OBSERVATION error message #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test ert please |
ManInFez
reviewed
Nov 19, 2021
BjarneHerland
force-pushed
the
fix-observations-errormsg
branch
2 times, most recently
from
0458c45 to
90a4d71
Compare
dafeda
reviewed
Nov 20, 2021
|
Now that the new tmpdir is merged, should we try using it here? I've with help from @eivindjahren made use of it here: #2425 |
dafeda
reviewed
Nov 25, 2021
|
test ert please
Working on it... 😄 |
BjarneHerland
force-pushed
the
fix-observations-errormsg
branch
from
90a4d71 to
a057e5c
Compare
dafeda
reviewed
Nov 25, 2021
|
|
||
| /* | ||
| * Set up workarea, create and write start of file. | ||
| * Returns pointer to workares since it needs to be kept alive |
There was a problem hiding this comment.
Type in "Returns pointer to workares since it needs to be kept alive", should be workarea
dafeda
reviewed
Nov 25, 2021
| * for the actual test | ||
| */ | ||
| void setup() { | ||
| util_make_path("obs_path"); |
There was a problem hiding this comment.
Use filesystem::create_directory instead?
dafeda
reviewed
Nov 25, 2021
BjarneHerland
force-pushed
the
fix-observations-errormsg
branch
from
a057e5c to
e5af8b1
Compare
|
test ert please |
|
test ert please |
3 similar comments
|
test ert please |
|
test ert please |
|
test ert please |
Replaced to dynamically report keywords for which files cannot be located, topped off with an extensive unit-test. The method conf_instance_has_path_error() is neither used not defined anywhere so declaration is removed from conf.hpp
BjarneHerland
force-pushed
the
fix-observations-errormsg
branch
from
e5af8b1 to
a5794d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #938. As a bonus, the method
conf_instance_has_path_error()is neither used not defined anywhere so declaration is removed fromconf.hppApproach
Replaced static text to dynamically report keywords for which files cannot be located, topped off with an extensive unit-test. A static (internal) method is used in
conf.cpp, utilizingstd::setto accumulate errors while avoiding duplicates. Keywords are separated by newline and returned aschar *since this method is exposed to C.