Add menu option to play live streams from beginning of stream #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a user starts playback of an in-progress game, the stream starts from wherever the live playback is currently up to. This has a high risk of spoilers.
This PR adds an option to the settings called "Start live stream playback from beginning" under a new submenu called "Playback". This controls a bool which is used to set the inputstream property
inputstream.adaptive.play_timeshift_bufferwhich, when set to true, will play any ongoing live streams from the beginning of the stream. (see https://github.com/xbmc/inputstream.adaptive/wiki/Integration#inputstreamadaptiveplay_timeshift_buffer )I originally wanted it to be chosen by the user on a per-stream basis, but that would have been more difficult and would also present the user with yet another dialog to click through when playing a stream which could be annoying. So the approach provided is probably cleaner anyway.