Skip to content

Commit

Permalink
Add actual bool_flags for the settings
Browse files Browse the repository at this point in the history
  • Loading branch information
lalten committed Nov 15, 2023
1 parent b1cc266 commit 0c54dfa
Show file tree
Hide file tree
Showing 4 changed files with 33 additions and 3 deletions.
4 changes: 3 additions & 1 deletion .bazelrc
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
build:clang-tidy --aspects @bazel_clang_tidy//clang_tidy:clang_tidy.bzl%clang_tidy_aspect
build:clang-tidy --output_groups=report
build:clang-tidy --output_groups=report
build:clang-tidy --@bazel_clang_tidy//:clang_tidy_bazel_out_includes_are_system_includes=True
build:clang-tidy --@bazel_clang_tidy//:clang_tidy_virtual_includes_are_system_includes=True
14 changes: 14 additions & 0 deletions BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
load("@bazel_skylib//rules:common_settings.bzl", "bool_flag")

filegroup(
name = "clang_tidy_config_default",
srcs = [
Expand Down Expand Up @@ -33,3 +35,15 @@ label_flag(
build_setting_default = ":clang_tidy_additional_deps_default",
visibility = ["//visibility:public"],
)

bool_flag(
name = "clang_tidy_bazel_out_includes_are_system_includes",
build_setting_default = False,
visibility = ["//visibility:public"],
)

bool_flag(
name = "clang_tidy_virtual_includes_are_system_includes",
build_setting_default = False,
visibility = ["//visibility:public"],
)
14 changes: 14 additions & 0 deletions WORKSPACE
Original file line number Diff line number Diff line change
@@ -1 +1,15 @@
workspace(name = "bazel_clang_tidy")

load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

maybe(
http_archive,
name = "bazel_skylib",
sha256 = "cd55a062e763b9349921f0f5db8c3933288dc8ba4f76dd9416aac68acee3cb94"
url = "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz",
)

load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")

bazel_skylib_workspace()
4 changes: 2 additions & 2 deletions clang_tidy/clang_tidy.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,8 @@ clang_tidy_aspect = aspect(
"_clang_tidy_executable": attr.label(default = Label("//:clang_tidy_executable")),
"_clang_tidy_additional_deps": attr.label(default = Label("//:clang_tidy_additional_deps")),
"_clang_tidy_config": attr.label(default = Label("//:clang_tidy_config")),
"_clang_tidy_bazel_out_includes_are_system_includes": attr.bool(default = False),
"_clang_tidy_virtual_includes_are_system_includes": attr.bool(default = False),
"_clang_tidy_bazel_out_includes_are_system_includes": attr.label(default = Label("//:clang_tidy_bazel_out_includes_are_system_includes")),
"_clang_tidy_virtual_includes_are_system_includes": attr.label(default = Label("//:clang_tidy_virtual_includes_are_system_includes")),
},
toolchains = ["@bazel_tools//tools/cpp:toolchain_type"],
)

0 comments on commit 0c54dfa

Please sign in to comment.