Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target to apply clang-tidy fixes #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oliverlee
Copy link
Contributor

No description provided.

@oliverlee oliverlee marked this pull request as ready for review January 6, 2023 17:08
@oliverlee
Copy link
Contributor Author

oliverlee commented Jan 6, 2023

When I run the example with:

bazel build //example --aspects clang_tidy/clang_tidy.bzl%clang_tidy_aspect --output_groups=report

this silently succeeds. If instead I run

bazel build //... --aspects clang_tidy/clang_tidy.bzl%clang_tidy_aspect --output_groups=report

I get the expected lint warning.

I get tidy fixes applied with

bazel run :apply_fixes

or

bazel run :apply_fixes -- //...

@gou4shi1
Copy link

any update?

@MiaoDX
Copy link

MiaoDX commented Nov 9, 2023

@oliverlee

Hi, tried to use the fix patch, however, it seems to be confused by sandbox.

I tried to add back no-sandbox inside 99ed470, it succeed in fixing the std::string problem.

dongxu@MiDX01:~/ws/micah/tmp/bazel_clang_tidy$ bazelisk run :apply_fixes //...
INFO: Invocation ID: 2334cead-3d8a-4851-9396-e18a3046da53
INFO: Analyzed target //:apply_fixes (1 packages loaded, 1 target configured).
INFO: Found 1 target...
Target //:apply_fixes up-to-date:
  bazel-bin/clang_tidy.apply_fixes.sh
INFO: Elapsed time: 0.045s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
INFO: Running command line: bazel-bin/clang_tidy.apply_fixes.sh //...
Described file '/home/dongxu/.cache/bazel/_bazel_dongxu/7cea99f25702216cc5bfbca1e10eeac0/sandbox/linux-sandbox/11/execroot/bazel_clang_tidy/example/lib.cpp' doesn't exist. Ignoring...
Described file '/home/dongxu/.cache/bazel/_bazel_dongxu/7cea99f25702216cc5bfbca1e10eeac0/sandbox/linux-sandbox/11/execroot/bazel_clang_tidy/example/lib.hpp' doesn't exist. Ignoring...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants