Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: all editors support #82

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

amirrezaDev1378
Copy link

@amirrezaDev1378 amirrezaDev1378 commented Feb 25, 2024

Added support for Webstom and all other editors that support web protocols

Copy link

changeset-bot bot commented Feb 25, 2024

⚠️ No Changeset found

Latest commit: 5613faf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@amirrezaDev1378
Copy link
Author

@ericclemmons

@AdoKevin
Copy link

This is exactly what I've been hunting for.

I'm trying to find a way to support opening files with vscode and remote ssh, it's protcol should look like vscode://vscode-remote/ssh-remote+host/home/file_to_open. However, there is a hardcoded ${editor}://file/ in the getUrl function and no hook to change it. If the awsome PR is merged, my problem's as good as solved!

@amirrezaDev1378
Copy link
Author

Another problem that it solves is that JetBrains IDEs may use slightly different web protocols in different versions and OS, this way you can specify your template.
@AdoKevin

@adi518
Copy link

adi518 commented Apr 26, 2024

Is webstorm an alias for intellij?

@alexgorbatchev
Copy link

I have published a fork which includes this PR https://github.com/alexgorbatchev/click-to-component-next

@alanhe421
Copy link
Contributor

Is webstorm an alias for intellij?

You can understand it this way: the URL rules of the two IDEs are the same, only the names are different.

@alanhe421
Copy link
Contributor

alanhe421 commented Dec 15, 2024

I have published a fork which includes this PR https://github.com/alexgorbatchev/click-to-component-next

For webstorm://open?file=
I tested it, IDEA, Pycharm don't support it, only WebStorm does, that's weird, I thought all JB's IDE's could use that template. For example

idea://open?file=/Users/alanhe/GitHub/click-to-component/apps/cra/src/App.js&line=10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants