refactor: change openai api key assignment and model list retrieval #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ericmjl
commented
Nov 11, 2023
ericmjl
commented
- Removed direct assignment of OpenAI API key in init.py
- Created an OpenAI client in configure.py using the API key from environment variable
- Replaced direct model list retrieval from OpenAI with client's model list method
- Reordered import statements for better organization
- Removed direct assignment of OpenAI API key in __init__.py - Created an OpenAI client in configure.py using the API key from environment variable - Replaced direct model list retrieval from OpenAI with client's model list method - Reordered import statements for better organization
This commit moves the filename generation logic into the condition that checks if a save_path is provided. This ensures that the filename generation logic is only executed when necessary, improving efficiency.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 62.31% 62.65% +0.34%
==========================================
Files 47 47
Lines 1799 1821 +22
==========================================
+ Hits 1121 1141 +20
- Misses 678 680 +2
☔ View full report in Codecov by Sentry. |
This commit refactors the ImageBot class in the imagebot.py file. The filename generation logic, which was previously inside the ImageBot class, has been extracted to a separate function named filename_bot. This function takes an image prompt as input and returns a filename generated by the SimpleBot. This change improves the modularity and readability of the code.
This commit updates the docstring for the filename_bot function in the imagebot.py file. The updated docstring now includes parameter and return value descriptions, providing more detailed information about the function's usage and output.
This commit introduces a new test for the ImageBot class in the llamabot library. The test checks the behavior of the call method when it is invoked outside of a Jupyter notebook and no save path is provided. The test ensures that the method correctly saves the image to a generated filename based on the prompt.
This commit removes the deadline for the test_codebot_instance function in the python_prompt_library test suite to prevent potential timeout issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.