Added support for other OpenGraph like tags #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twitter and OpenGraph have been split apart. I made all attempts to respect OpenGraph as the default provider, while allowing either to be used very easily. Each 'Provider' can have different required attributes, as well as the attribute we key off of for finding these tags. Passing **provider** to OpenGraph() will force a Provider. If any OpenGraph tags are found, OpenGraph becomes the Provider, which forces validity of OpenGraph instead of the original Provider. is_valid() has been modified such that it will use the detected Provider. If tags of mixed providers are found, OpenGraph will take precedence. to_html() has been altered to print using the Provider's name. OrderedDict from collections is used to keep OpenGraph as top priority.
|
I'm not sure if you ever wanted to support other Providers, but I figured I'd share the code with you. Thanks for writing opengraph :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twitter and OpenGraph have been split apart. I made all attempts to respect OpenGraph as the default provider, while allowing either to be used very easily.
Each 'Provider' can have different required attributes, as well as the attribute we key off of for finding these tags.
Passing provider to OpenGraph() will force a Provider. If any OpenGraph tags are found, OpenGraph becomes the Provider, which forces validity of OpenGraph instead of the original Provider.
is_valid() has been modified such that it will use the detected Provider. If tags of mixed providers are found, OpenGraph will take precedence.
to_html() has been altered to print using the Provider's name.
OrderedDict from collections is used to keep OpenGraph as top priority.